[tor-bugs] #16666 [Tor]: ed25519-donna doesn't build on arm without warnings with the stack protector

Mon Jul 27 00:52:24 UTC 2015

#16666: ed25519-donna doesn't build on arm without warnings with the stack
protector
-------------------------+----------------------------------
     Reporter:  yawning  |      Owner:  yawning
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:  Tor: 0.2.7.2-alpha
   Resolution:           |   Keywords:  tor-core, tor-crypto
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+----------------------------------

Comment (by yawning):

 Ugh.  I don't know wtf I was thinking when I wrote that first branch.
 This does the right thing, sorry.  I went and changed it to only align to
 16 byte boundaries for SSE2 builds since it beats special casing SSP
 builds on every single non-x86 target.  Tested on x86_64, but we never
 build with SSE2 due to performance penalty so the code does work.

 https://github.com/Yawning/tor/compare/bug16666_take2

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16666#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online