[tor-bugs] #16236 [Tor Browser]: Windows updater: avoid writing to the Windows registry for "in use" files

[Tor Bug Tracker & Wiki]

#16236: Windows updater: avoid writing to the Windows registry for "in use" files
-------------------------+-------------------------------------------------
     Reporter:  mcs      |      Owner:  mcs
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  tbb-5.0a4, tbb-disk-leak,
   Resolution:           |  TorBrowserTeam201507R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mikeperry):

 This looks OK, I think, though I'm not sure it does exactly what the
 commit message says. Apparently there already was code to try to delete
 this directory at startup (based on the comment and surrounding code)?
 Doesn't that indicate that the extra deletion attempt in ProcessUpdates()
 is probably unnecessary?

 How risky is this in general? Is the most likely failure mode that users
 end up with a pile of stuff in tobedeleted? It looks like we're safe
 against namespace collision due to the use of random temporary directory
 names... Should we take any precautions with respect to not rolling this
 out in 5.0-stable until we've had an additional alpha or two?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16236#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online