[tor-bugs] #16540 [Onionoo]: Close the the updater's shared HttpUrlConnection socket if an exceptions occurs.

[Tor Bug Tracker & Wiki]

#16540: Close the the updater's shared HttpUrlConnection socket if an exceptions
occurs.
-------------------------------------------------+-------------------------
 Reporter:  leeroy                               |          Owner:
     Type:  defect                               |         Status:  new
 Priority:  normal                               |      Milestone:
Component:  Onionoo                              |        Version:
 Keywords:  onionoo httpurlconnection            |  Actual Points:
  descriptordownloader could not fetch or parse  |         Points:
  store                                          |
Parent ID:                                       |
-------------------------------------------------+-------------------------
 When Onionoo's updater uses a HttpUrlConnection it doesn't attempt to
 close the socket after an exception. An exception may occur anytime during
 or after the first fetchRemoteDirectory of DescriptorSource. The problem
 is this can leave the HttpUrlConnection's shared underlying network
 connection in a state which blocks further requests. This has the effect
 of preventing reads as early as during the first fetchRemoteFiles.
 Onionoo's updater will then block until the problem HttpUrlConnection is
 handled.

 To reproduce. Close the connection remotely during fetchRemoteDirectory.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16540>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online