[tor-bugs] #16299 [Stem]: Stem unit test failure for test_compare_flags

[Tor Bug Tracker & Wiki]

#16299: Stem unit test failure for test_compare_flags
------------------------+--------------------------
     Reporter:  atagar  |      Owner:  atagar
         Type:  defect  |     Status:  needs_review
     Priority:  minor   |  Milestone:
    Component:  Stem    |    Version:
   Resolution:          |   Keywords:  testing
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------

Comment (by cypherpunks):

 Replying to [comment:5 atagar]:
 > Hi cypherpunks, great catch! However, I'm a bit concerned that we're
 making the compare_flags.py example considerably less performant. We
 issued queries in parallel, but now it's serial. Can we fix the test
 without slowing down the example?
 Can you explain why you think the patch changes the execution from
 parallel to serial? It still calls `run()` for every query which AFAICT
 spawns threads.

 The patch moves the `run()` calls into the `get_authorities` loop which
 removes one for loop. Therefore, i expect the patch to improve performance
 even though this wasn't the goal of the patch (nor this ticket).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16299#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online