[tor-bugs] #16467 [Tor]: Faster Ed25519 implementation.
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sun Jul 5 02:31:46 UTC 2015
#16467: Faster Ed25519 implementation.
-----------------------------+------------------------------------
Reporter: yawning | Owner:
Type: enhancement | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.7.x-final
Component: Tor | Version: Tor: 0.2.7
Resolution: | Keywords: performance, tor-relay
Actual Points: | Parent ID: #9663
Points: |
-----------------------------+------------------------------------
Comment (by teor):
Code review using clang (Xcode 6.4 (6E35b) Apple LLVM version 6.1.0
(clang-602.0.53) (based on LLVM 3.6.0svn)) on OS X 10.10.4.
Build & static analysis:
clang would prefer iters to be a `#define`
{{{
test_crypto_ed25519_fuzz_donna(void *arg)
{
const int iters = 1024;
uint8_t msg[iters];
}}}
`tor/src/test/test_crypto.c:1643:15: Variable length array folded to
constant array as an extension`
Other than that, there are no build or static analyzer complaints from
clang.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16467#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list