[tor-bugs] #16480 [Tor]: connection_write_to_buf: indirect recursion for CONN_TYPE_CONTROL

[Tor Bug Tracker & Wiki]

#16480: connection_write_to_buf: indirect recursion for CONN_TYPE_CONTROL
-----------------------------+-----------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  new
     Priority:  normal       |  Milestone:
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------

Comment (by cypherpunks):

 Not sure about sanity of 2 and 3 way either. Only proper way to escape
 recursion is to separate writing to outbuf and flushing of outbuf by
 removing ability for immediate flush of outbuf. Do we really need to flush
 it such way for control port:
 {{{
                conn->outbuf_flushlen-len < 1<<16 &&
                conn->outbuf_flushlen >= 1<<16
 }}}
 what is profit, when it happens, why it happens?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16480#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online