[tor-bugs] #10395 [Tor]: Tor's consensus lists Torbrowser updates

[Tor Bug Tracker & Wiki]

#10395: Tor's consensus lists Torbrowser updates
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mikeperry
  StrangeCharm           |     Status:  needs_review
         Type:           |  Milestone:  Tor: 0.2.6.x-final
  enhancement            |    Version:
     Priority:  major    |   Keywords:  pantheon chronos prop227 nickm-
    Component:  Tor      |  patch
   Resolution:           |  Parent ID:  #10393
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gk):

 Replying to [comment:22 nickm]:
 > Thanks!  Typos fixed; added a consensus/valid-after GETINFO.  Better?

 The changes look good to me. The prop227 implementation looks good to me,
 too. Two nits and one question:

 1) `DIGESTTYPE` is now specified in prop227. You might want to add that to
 the "The grammar is" comment in dirserv.c, too.

 2) s/Skip digestname=digestval/Skip digesttype=digestval/ <- might be a
 bit more consistent

 3) `validate_recommended_package_line()` in dirserv.c allows digest type
 and value constructs like
 "=foobar
 sha256=3c179f46ca77069a6a0bac70212a9b3b838b2f66129cb52d568837fc79d8fcc7"
 or
 "= =
 sha256=3c179f46ca77069a6a0bac70212a9b3b838b2f66129cb52d568837fc79d8fcc7"
 if I see that correctly. Is that intentional and if so what is the
 reasoning behind it? I am wondering if that is even contrary to the spec
 as I am inclined to interpret "any number of characters" as implying "at
 least one character". But maybe I am mistaken.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10395#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online