[tor-bugs] #11485 [Tor]: support unix-sockets as hidden-service endpoints

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jan 28 15:40:47 UTC 2015


#11485: support unix-sockets as hidden-service endpoints
-----------------------------+----------------------------------
     Reporter:  meejah       |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-hs 026-triaged-1
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------------

Comment (by nickm):

 ba9aed237495bb263594c79daa75042e4dd0780e:
   * Prefer !strcmpstart(a,b) to strstr(a,b)==a
   * prefer tor_strdup() or tor_strndup() to malloc-plus-strncpy?
   * I think there should generally be a separate alloc function for types
 with variable-length members.

 fd29c898cb68e702e43f72a3669308dee0e7c2f1:
   * Isn't connection_connect_unix mostly a duplicate of
 connection_connect()?  We should combine them, or extract the common
 parts.

 de86ab3cc3321930f55b11ca3d9c1c005d608e92:
   * prefer tor_strdup() or tor_strndup() to malloc-plus-strncpy?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11485#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list