[tor-bugs] #14350 [Tor]: configure.ac: fix disabling systemd notification support

[Tor Bug Tracker & Wiki]

#14350: configure.ac: fix disabling systemd notification support
--------------------------+--------------------------------
     Reporter:  blueness  |      Owner:
         Type:  defect    |     Status:  needs_review
     Priority:  normal    |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor       |    Version:
   Resolution:            |   Keywords:
Actual Points:            |  Parent ID:
       Points:            |
--------------------------+--------------------------------
Changes (by nickm):

 * status:  new => needs_review


Comment:

 But there's another occurrence of "$enable_systemd" later in the file;
 shouldn't this one change too?
 {{{
 if test x$enable_systemd = xyes -a x$have_systemd != xyes ; then
     AC_MSG_ERROR([Explicitly requested systemd support, but systemd not
 found])
 fi
 }}}

 Maybe it would be better to do:
 {{{
 diff --git a/configure.ac b/configure.ac
 index 9aac1e8..89fa882 100644
 --- a/configure.ac
 +++ b/configure.ac
 @@ -118,10 +118,10 @@ AC_ARG_ENABLE(upnp,
  AC_ARG_ENABLE(systemd,
        AS_HELP_STRING(--enable-systemd, enable systemd notification
 support),
        [case "${enableval}" in
 -        yes) systemd=true ;;
 -        no)  systemd=false ;;
 +        yes) enable_systemd=true ;;
 +        no)  enable_systemd=false ;;
          * ) AC_MSG_ERROR(bad value for --enable-systemd) ;;
 -      esac], [systemd=auto])
 +      esac], [enable_systemd=auto])
 }}}

 What do you think?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14350#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online