[tor-bugs] #14316 [Pluggable transport]: Obfs4proxy commit cdeda5724124ca393c87be6d01c84fe4f906d612 breaks nightly builds

[Tor Bug Tracker & Wiki]

#14316: Obfs4proxy commit cdeda5724124ca393c87be6d01c84fe4f906d612 breaks nightly
builds
-------------------------------------+-------------------------------
     Reporter:  gk                   |      Owner:  yawning
         Type:  defect               |     Status:  accepted
     Priority:  normal               |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:                       |   Keywords:  tbb-gitian, obfs4
Actual Points:                       |  Parent ID:
       Points:                       |
-------------------------------------+-------------------------------

Comment (by yawning):

 Replying to [comment:3 gk]:
 > I think just using the commit before the broken one and fixing the
 gitian bits once we switch to the new obfs4 tag might be the simplest
 solution. But I would not be opposed to the more heavyweight things if you
 e.g. think you'd like to have the latest and greatest obfs4 in the
 nightlies (for instance for testing purposes).

 This should fix the problem correctly:
  * https://github.com/Yawning/tor-browser-bundle/compare/bug14316

 Note:
  * Once obfs4proxy 0.0.4 is out and being build by all the targets the
 older `GOCRYPTO` stuff **SHOULD** be removed.
  * Once we switch to Go 1.4.x or later, the older `GOCRYPTO` stuff
 **MUST** be removed, since it will break the build (Guess why I made the
 offending commit in the first place).  The new code that I added to the
 build process is backward compatible though so it will build (though not
 get used) for the alpha target just fine.

 HTH, let me know if I screwed something up.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14316#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online