[tor-bugs] #14219 [Tor]: Visiting a down hidden service that was recently up results in many hsdesc fetches

[Tor Bug Tracker & Wiki]

#14219: Visiting a down hidden service that was recently up results in many hsdesc
fetches
------------------------+------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.???
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  SponsorR, tor-hs
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------

Comment (by arma):

 This fixes it for me:
 {{{
 diff --git a/src/or/rendcommon.c b/src/or/rendcommon.c
 index 88d9aab..82202b9 100644
 --- a/src/or/rendcommon.c
 +++ b/src/or/rendcommon.c
 @@ -1251,19 +1251,12 @@ rend_cache_store_v2_desc_as_client(const char
 *desc,
    /* Do we already have a newer descriptor? */
    tor_snprintf(key, sizeof(key), "2%s", service_id);
    e = (rend_cache_entry_t*) strmap_get_lc(rend_cache, key);
 -  if (e && e->parsed->timestamp > parsed->timestamp) {
 -    log_info(LD_REND, "We already have a newer service descriptor for "
 +  if (e && e->parsed->timestamp >= parsed->timestamp) {
 +    log_info(LD_REND, "We already have a new enough service descriptor
 for "
                        "service ID %s with the same desc ID and version.",
               safe_str_client(service_id));
      goto okay;
    }
 -  /* Do we already have this descriptor? */
 -  if (e && !strcmp(desc, e->desc)) {
 -    log_info(LD_REND,"We already have this service descriptor %s.",
 -             safe_str_client(service_id));
 -    e->received = time(NULL);
 -    goto okay;
 -  }
    if (!e) {
      e = tor_malloc_zero(sizeof(rend_cache_entry_t));
      strmap_set_lc(rend_cache, key, e);
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14219#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online