[tor-bugs] #13749 [Tor Browser]: Write tests for privacy.thirdparty.isolate

[Tor Bug Tracker & Wiki]

#13749: Write tests for privacy.thirdparty.isolate
-----------------------------+-----------------------------------
     Reporter:  mikeperry    |      Owner:  arthuredelstein
         Type:  task         |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  TorBrowserTeam201501R
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------------

Comment (by arthuredelstein):

 To confirm that the second patch reports what we think it should, I first
 reverted the cache patch

 {{{
 > git revert 8425b9a358211777543303d2194b378b2765f144
 [13749 e29d844] Revert "Bug 13742: Isolate cache to URL bar domain."
  1 file changed, 2 insertions(+), 16 deletions(-)
 }}}

 The result was all tests when the isolation is activated (including image
 caching) fail:

 {{{
  0:29.04 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for iframe.html: 4
  0:29.04 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for link.css: 4
  0:29.04 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for script.js: 4
  0:29.04 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for img.png: 4
  0:29.04 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for object.png: 4
  0:29.04 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for embed.png: 4
  0:29.04 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for xhr.html: 4
  0:29.04 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for audio.ogg: 4
  0:29.04 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for video.ogv: 4
  0:29.04 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for track.vtt: 4
 }}}

 then I brought back that patch and instead reverted the image cache
 isolation patch:

 {{{
 > git revert 114cd22282f8b3cd6e6a5c29de8a8c396a79acc0
 [13749 0236e36] Revert "Bug #6539: Isolate the Image Cache per url bar
 domain."
  12 files changed, 156 insertions(+), 274 deletions(-)
 }}}

 and the result was that image caching tests fail:

 {{{
  0:32.53 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for img.png: 4
  0:32.53 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for object.png: 4
  0:32.53 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for embed.png: 4
  0:32.53 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for img.png: 1
  0:32.53 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for object.png: 1
  0:32.53 TEST-UNEXPECTED-FAIL |
 chrome://mochitests/content/browser/netwerk/test/browser/browser_cacheFirstParty.js
 | Cache entries expected for embed.png: 1
 }}}

 So I feel pretty comfortable that these regression tests are testing what
 they are supposed to be testing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13749#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online