[tor-bugs] #13806 [Tor]: Count HSDir storage towards MaxMemInQueues

[Tor Bug Tracker & Wiki]

#13806: Count HSDir storage towards MaxMemInQueues
------------------------+-------------------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay tor-hs oom security
Actual Points:          |  Parent ID:
       Points:          |
------------------------+-------------------------------------------

Comment (by dgoulet):

 Btw, we had this fellow on #tor-dev that showed me that he could in a few
 seconds create a valid descriptor for a specific HSDir and upload it (I
 didn't validate his PoC). The hs descriptor storage uses digest map which
 has a upper bound for memory but returns 0 if that limit is reached which
 means that {{{rend_cache_store_v2_desc_as_dir()}}} thinks that the
 descriptor was stored (when it fact it was not) thus not freeing the
 memory of the descriptor.

 This could lead to a memory exhaustion attack which this ticket could
 mitigate!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13806#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online