[tor-bugs] #14859 [Onionoo]: Adapt Onionoo's parsing code for MaxMind's GeoLite2 City files to their new format
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Feb 18 11:50:49 UTC 2015
#14859: Adapt Onionoo's parsing code for MaxMind's GeoLite2 City files to their new
format
-------------------------+-----------------
Reporter: karsten | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: Onionoo | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
-------------------------+-----------------
Changes (by karsten):
* status: needs_review => new
Comment:
Agreed about adding more tests for other special characters later.
I'm not sure how to verify that the MaxMind files are actually UTF-8
encoded. That's different from writing our own unit tests where we
provide our own data. This verification code would have to run in the
production code and somehow detect the character encoding when parsing
MaxMind's files. Any idea how to do that?
I just merged the branch to master. I'll leave this ticket open until we
have resolved the minor remaining issues above.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14859#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list