[tor-bugs] #17893 [Tor]: Stop building and testing Tor twice when running distcheck

[Tor Bug Tracker & Wiki]

#17893: Stop building and testing Tor twice when running distcheck
-----------------------------+--------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  new
     Priority:  Low          |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor          |    Version:  Tor: unspecified
     Severity:  Trivial      |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |    Sponsor:
-----------------------------+--------------------------------
 In commit 9f6b9e28ccfdc3a96fb6e28d5121539f3cba3c55 the steps for putting
 out a new Tor release changed from running `make check` to `make
 distcheck`. With this change there is no need for the dist rule in
 Makefile.am:76 anymore.

 The rule causes Tor to be built and tested twice when `make distcheck` is
 called (once in the current build directory and other time in the
 temporary distcheck build directory). This is caused by the `distcheck`
 rule calling our `dist` rule which calls the internal `check` rule which
 triggers the `all` rule.

 The removal would make the workflow of testing build configuration changes
 faster (especially on slower machines) by not having to wait on the first
 compilation and testing phase which is performed by distcheck anyway.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17893>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online