[tor-bugs] #17592 [Tor]: Clean up connection timeout logic

[Tor Bug Tracker & Wiki]

#17592: Clean up connection timeout logic
-----------------------+------------------------------------
 Reporter:  mikeperry  |          Owner:  mikeperry
     Type:  defect     |         Status:  needs_review
 Priority:  High       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor        |        Version:
 Severity:  Normal     |     Resolution:
 Keywords:             |  Actual Points:
Parent ID:  #16861     |         Points:
  Sponsor:             |
-----------------------+------------------------------------
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:7 teor]:
 > This patch looks good to me in general.
 >
 > I like the change from port 80 as the default predicted port to port
 443.
 >
 > In options_validate:
 > * Should we put minimum and maximum values on CircuitsAvailableTimeout,
 like the previous code for PredictedPortsRelevanceTime?

 I think the only reason why we had minimum and maximum values here was due
 to the concerns about discrepancy between PredictedPortsRelevanceTime and
 CircuitIdleTimeout. CircuitIdleTimeout never had any ranges or limits. At
 least, that was my read of
 https://trac.torproject.org/projects/tor/ticket/9176#comment:7.

 > A nitpick:
 >
 > In channelpadding_get_channel_idle_timeout:
 > * I think `server_mode()` is the standard way of checking
 `options->BridgeRelay || !options->ORPort_set`. It does a few more checks,
 as far as I recall.

 Ok, I fixed this and another instance in fixup commits atop
 netflow_padding-v4.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17592#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online