[tor-bugs] #17792 [Tor Browser]: Donation banner translations

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Dec 11 10:31:59 UTC 2015


#17792: Donation banner translations
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  funding, crowdfunding, donations,    |        Version:
  TorBrowserTeam201512R                          |     Resolution:
Parent ID:  #17534                               |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------
Changes (by gk):

 * parent:   => #17534


Comment:

 Looks good. One nit:
 {{{
       div = document.getElementById("donation-banner-" + suffix);
       div.innerHTML = text;
 }}}
 You either got the indentation wrong for `div.innerHTML = text` or wanted
 to have a "," and not a ";". I am taking the patch as is for the stable
 hoping that we finally can get a build going. Could you fix that for
 master?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17792#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list