[tor-bugs] #17776 [Tor]: Buffer over-reads in directory and rendcache tests

[Tor Bug Tracker & Wiki]

#17776: Buffer over-reads in directory and rendcache tests
-------------------------------+------------------------------------
 Reporter:  cypherpunks        |          Owner:  cypherpunks
     Type:  defect             |         Status:  needs_review
 Priority:  Medium             |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor                |        Version:  Tor: 0.2.7.3-rc
 Severity:  Normal             |     Resolution:
 Keywords:  TorCoreTeam201512  |  Actual Points:
Parent ID:                     |         Points:
  Sponsor:                     |
-------------------------------+------------------------------------
Changes (by cypherpunks):

 * status:  assigned => needs_review


Comment:

 Patch 5 updates the comments to mention the expected digest length. (Going
 to open a separate ticket about the `intro_entry` parameter staying
 untouched, because it isn't)

 Turns out the rendcache functions that were tested in the code that patch
 1 and 2 patches passes their parameters to the digest map functions. The
 digest map functions already assert for the map, the key, and the value
 not to be `NULL` so no extra asserts are needed here.

 The `dir_server_new` function (which is used by `trusted_dir_server_new`)
 did miss one assert so patch 6 adds that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17776#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online