[tor-bugs] #17762 [Tor]: Complaint of malformed IP/policy

[Tor Bug Tracker & Wiki]

#17762: Complaint of malformed IP/policy
-------------------------+------------------------------------
 Reporter:  tmpname0901  |          Owner:
     Type:  defect       |         Status:  needs_review
 Priority:  Very High    |      Milestone:  Tor: 0.2.7.x-final
Component:  Tor          |        Version:  Tor: 0.2.7.5
 Severity:  Critical     |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+------------------------------------
Changes (by teor):

 * status:  needs_information => needs_review


Comment:

 This issue is already fixed in master as a result of refactoring.

 Please see my branch avoid-fmt-addr-policy on
 https://github.com/teor2345/tor.git , which cherry-picks this commit, and
 adds a changes file.

 The previous code relied on fmt_addr, which sometimes returns "???". This
 can cause an error parsing the exit policy, which could result in the
 entire exit policy being discarded.

 This code directly copies the tor_addr_t into the exit policy structure,
 avoiding the fmt_addr/parsing steps.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17762#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online