[tor-bugs] #16906 [Tor Browser]: Code for 38.3.0 ESR is failing to compile with mingw-w64

[Tor Bug Tracker & Wiki]

#16906: Code for 38.3.0 ESR is failing to compile with mingw-w64
----------------------------+----------------------------------------------
     Reporter:  gk          |      Owner:  tbb-team
         Type:  defect      |     Status:  new
     Priority:  blocker     |  Milestone:
    Component:  Tor         |    Version:
  Browser                   |   Keywords:  tbb-gitian, TorBrowserTeam201508
   Resolution:              |  Parent ID:
Actual Points:              |
       Points:              |
----------------------------+----------------------------------------------
Changes (by mcs):

 * cc: brade, mcs (added)


Comment:

 I see there is a proposed fix.  Yesterday, Kathy and I spent some time
 looking at the changes associated with Mozilla bug 1177861 because we
 thought that changeset was going to be part of the imminent release. It
 may be that the code that introduces a dependency on the wintrust and
 crypt32 DLLs is not needed in Tor Browser.  I do not think it will ever be
 called by our updater, which means it may be better for Tor Browser to not
 build that code at all.  Previously, most of it was part of the
 maintenance service which we omit.  But we will need to examine our code
 closely to confirm that it is not needed and then decide if it is
 worthwhile to patch things to remove the dependency.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16906#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online