[tor-bugs] #13512 [Tor Browser]: After update, load a static tab with change notes
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Aug 24 20:08:29 UTC 2015
#13512: After update, load a static tab with change notes
-------------------------+-------------------------------------------------
Reporter: arma | Owner: mcs
Type: | Status: needs_review
enhancement | Milestone:
Priority: normal | Version:
Component: Tor | Keywords: tbb-usability,
Browser | TorBrowserTeam201508R, GeorgKoppen201508R
Resolution: | Parent ID:
Actual Points: |
Points: |
-------------------------+-------------------------------------------------
Comment (by gk):
Replying to [comment:25 gk]:
> Replying to [comment:24 mcs]:
> > Replying to [comment:23 gk]:
> > > Here is what I did:
> > > ...
> > > 5) I generated the XML files for the updater and checked that
boklm's patch did indeed include the additional attributes
> > > 6) I took a MAR file and signed it
> > > 7) I applied that MAR file manually to 5.0a4
> > > 8) I restarted and just got an about:tor page but no "You
successfully updated Tor Browser" dialog
> >
> > Does your step 7 only run the updater manually (i.e.,
https://wiki.mozilla.org/Software_Update:Manually_Installing_a_MAR_file)
or does an update.xml file (from step 5) get downloaded and placed inside
updates.xml where the browser expects to find it? In other words, does
your procedure update the update history? If not, the "showURL" action
won't be found. See http://mxr.mozilla.org/mozilla-
esr38/source/browser/components/nsBrowserContentHandler.js#148 (the
getPostUpdateOverridePage() function).
>
> Yes, that seems to be the bit I missed. Interestingly this causes things
like
[...]
> to happen on restart. Not sure if that is expected.
This is not due to your patches it turns out. I just updated 4.5a5 to
5.5a1 and get the same stuff on my testing machine. Interesting, but
probably a different ticket :)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13512#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list