[tor-bugs] #16791 [Tor]: All modules in src/common should have 90-95%+ unit test coverage

[Tor Bug Tracker & Wiki]

#16791: All modules in src/common should have 90-95%+ unit test coverage
---------------------+------------------------------------
 Reporter:  nickm    |          Owner:
     Type:  project  |         Status:  new
 Priority:  normal   |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor      |        Version:
 Keywords:           |  Actual Points:
Parent ID:           |         Points:
---------------------+------------------------------------
 It's a dirty shame to have anything in src/common that isn't really deeply
 covered by our unit tests, since src/common is supposed to be full of
 stuff that's ''easy'' to test.

 As of 2015-08-13, here's what's problematic (running "make check") on OSX,
 sorted by percentage of lines covered.
 {{{
 x/procmon.c.gcov 45 0 0.00
 x/sandbox.c.gcov 9 0 0.00
 x/compat_libevent.c.gcov 92 32 25.81
 x/tortls.c.gcov 593 355 37.45
 x/log.c.gcov 274 274 50.00
 x/compat_threads.c.gcov 48 51 51.52
 x/compat.c.gcov 360 426 54.20
 x/torgzip.c.gcov 88 136 60.71
 x/util.c.gcov 484 1263 72.30
 x/compat_pthreads.c.gcov 22 72 76.60
 x/workqueue.c.gcov 34 117 77.48
 x/crypto.c.gcov 204 738 78.34
 x/memarea.c.gcov 20 85 80.95
 x/backtrace.c.gcov 9 42 82.35
 x/crypto_ed25519.c.gcov 17 95 84.82
 x/util_process.c.gcov 5 33 86.84
 x/address.c.gcov 77 595 88.54
 x/crypto_curve25519.c.gcov 8 74 90.24
 x/crypto_s2k.c.gcov 14 152 91.57
 x/util_format.c.gcov 11 183 94.33
 x/crypto_format.c.gcov 5 95 95.00
 x/container.c.gcov 15 390 96.30
 x/crypto_pwbox.c.gcov 2 59 96.72
 x/di_ops.c.gcov 1 37 97.37
 x/aes.c.gcov 0 17 100.00
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16791>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online