[tor-bugs] #15816 [Tor]: HS Descriptor Fetch retry behavior is broken.

[Tor Bug Tracker & Wiki]

#15816: HS Descriptor Fetch retry behavior is broken.
-------------------------+--------------------------------
     Reporter:  yawning  |      Owner:
         Type:  defect   |     Status:  needs_revision
     Priority:  major    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:  Tor: 0.2.7
   Resolution:           |   Keywords:  SponsorR tor-hs
Actual Points:           |  Parent ID:
       Points:  medium   |
-------------------------+--------------------------------

Comment (by dgoulet):

 Replying to [comment:2 special]:
 > I don't have time to look closely now; but a quick reaction:
 >
 > 18f61f97e73c801ab942bf92d0aa95182744d65e
 >
 > * descriptor_id and desc_id_fetch are used as NUL-terminated strings,
 but rend_compute_v2_desc_id actually provides a binary digest.
 > (looks like that was a preexisting problem too)

 Good catch! Fixed that, now using `memcpy`.

 > * rend_data_create is not very nice API. Redundant (pk_digest and
 onion_address), mutually exclusive (onion_address and desc_id), and
 confusing (descriptor_cookie and cookie) parameters. Weird to take
 descriptor_cookie but not auth_type.

 True, new branch seperates them by service and client using the right
 arguments that each needs.

 Also FYI, if we merge this, #15822 is fixed with this work. :)

 See `bug15816_027_03`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15816#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online