[tor-bugs] #15672 [Tor Browser]: Provide command line args to register Tor Browser as a Linux desktop app

[Tor Bug Tracker & Wiki]

#15672: Provide command line args to register Tor Browser as a Linux desktop app
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mikeperry
  mikeperry              |     Status:  closed
         Type:           |  Milestone:
  enhancement            |    Version:
     Priority:  normal   |   Keywords:  tbb-4.5-alpha,
    Component:  Tor      |  TorBrowserTeam201504R
  Browser                |  Parent ID:
   Resolution:  fixed    |
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:3 mikeperry]:
 > Replying to [comment:2 gk]:
 > > Looks good to me (I don't see that Unity bug on an Ubuntu 12.04 btw).
 Two things that I was thinking about while looking at the code and
 testing:
 > >
 > > 1) Why not allowing `--debug` and, say, `--register-app` at the same
 time? I.e. being able to use more than one command line argument might be
 handy.
 >
 > I think we should file another ticket for multiple arg support if we
 really want that. It is a bit risky to try at this point for 4.5. Right
 now though, --register-app and --unregister-app do not squelch output of
 the script or the commands it calls, so --debug seems unnecessary.

 Ah, you got me wrong. What I really had in mind was something like
 registering the app and then starting Tor Browser in debug mode just with
 `./start-tor-browser.desktop --register-app --debug` or maybe a user just
 wants to unregister the app + using debug mode from now on with `./start-
 tor-browser.desktop --unreigster-app --debug`

 > > 2) Instead of copying `start-tor-browser.desktop` again and again if a
 user is starting with `--register-app` several times you could do the same
 as in the "unregistering" case: check if the file already exists and if so
 saying that to the user and otherwise copying the .desktop file.
 >
 > I thought about this, but I wanted to make the usecase where the user
 has relocated their TBB and needs to reregister the app as a result (to
 update the paths) not require multiple steps. Simply running the register
 step without existence checks seemed the simplest way to accomplish this.

 Good point. I merged your branch in commit
 44e59e8d6e91bab002d93a978b8a4e36fbb5b9fb.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15672#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online