[tor-bugs] #1944 [Torperf]: Set up a Torperf to a hidden service

[Tor Bug Tracker & Wiki]

#1944: Set up a Torperf to a hidden service
-------------------------+----------------------
     Reporter:  arma     |      Owner:
         Type:  task     |     Status:  assigned
     Priority:  normal   |  Milestone:
    Component:  Torperf  |    Version:
   Resolution:           |   Keywords:  SponsorR
Actual Points:           |  Parent ID:  #2552
       Points:  3        |
-------------------------+----------------------

Comment (by asn):

 Replying to [comment:16 karsten]:
 > Hang on, arma's patch contains a bug:
 >
 > {{{
 >     rend_cache_clean(1000000);
 >     rend_cache_clean_v2_descs_as_dir(1000000);
 > }}}
 >
 > That timestamp is 1970-01-12T14:46:40, and these two calls will only
 remove descriptors published three days *before* that timestamp.  arma's
 bug1944 branch contains one more zero, but 10000000 is still
 1970-04-26T18:46:40 and much too old.  A better number would be 2000000000
 which is 2033-05-18T05:33:20.  Or we can avoid timestamp maths and just
 use:
 >
 > {{{
 >     rend_cache_purge();
 > }}}
 >
 > Similarly, I put in a call for
 `rend_client_purge_last_hid_serv_requests()` rather than the suggested
 `directory_clean_last_hid_serv_requests()`.
 >


 Yes, that seems like a bug indeed.

 Replacing `rend_cache_clean()` with `rend_cache_purge()` seems like the
 correct thing to do.

 There was also a call to `rend_cache_clean_v2_descs_as_dir()` but this
 seems to be used in HSDirs, not in clients. I see you didn't replace that
 with something in your full patch, which makes sense to me (since we are
 not HSDirs) but maybe arma was thinking of something?

 BTW, I'm not very familiar with this part of the HS code (how IP/RP
 connections are organized), so I might be wrong.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1944#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online