[tor-bugs] #13163 [Tor]: Alternate{Dir, Bridge}Authority aren't sufficient for fully internal TestingTorNetwork

[Tor Bug Tracker & Wiki]

#13163: Alternate{Dir,Bridge}Authority aren't sufficient for fully internal
TestingTorNetwork
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:  Tor: unspecified
   Resolution:           |   Keywords:  tor-config tor-authority tor-test-
Actual Points:           |  network
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------
Changes (by teor):

 * status:  new => needs_review


Comment:

 I created patches to implement option 1 - the usage of NO_DIRINFO in
 consider_adding_dir_servers(). In many other functions, NO_DIRINFO is used
 to mean "don't care" or "all".

 == 01-AlternateAuthorities-alway-use-default-authorities.patch
 This patch fixes the issue where networks that use both
 AlternateDirAuthority and AlternateBridgeAuthority still have the default
 authorities.

 ==  02-AlternateAuthorities-restrict-to-declared-type.patch
 This patch restricts the types of alternate authorities to the type they
 are declared as - for exampe, a bridge authority will only be of bridge
 type. This might not be ok - it would stop bridge authorities being asked
 for microdescriptors, for example.

 == 03-UseBridges-check-bridge-type-bit.patch​
 A few lines of code in directory_get_from_dirserver() in directory.c use
 type == BRIDGE_DIRINFO rather than type & BRIDGE_DIRINFO. This patch fixes
 them so they use bitwise and like all other dirinfo checks.

 == 04-dirinfo-type-expand-comments-explicit-constants.patch

 Passing NO_DIRINFO to various functions is sometimes left undocumented.
 This patch expands the documentation around NO_DIRINFO. It also changes
 zeroes to NO_DIRINFO where appropriate. An unrelated by nearby comment is
 repositioned near its code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13163#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online