[tor-bugs] #11638 [Tor]: Backport raising of #9731 fixes.

[Tor Bug Tracker & Wiki]

#11638: Backport raising of #9731 fixes.
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  robgjansen             |     Status:  reopened
         Type:  defect   |  Milestone:  Tor: 0.2.4.x-final
     Priority:  normal   |    Version:  Tor: 0.2.4.21
    Component:  Tor      |   Keywords:  tor-relay, shadow, infinite, loops,
   Resolution:           |  arma-backport-02422
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by robgjansen):

 Replying to [comment:21 nickm]:
 > >I want 0.2.4.x to work with Shadow, since I've had a fair number of
 requests for it.
 >
 > To clarify, this means that the approach of saying "apply this patch if
 you want to run Tor 0.2.4.x with Shadow" is not working?

 I think I misunderstood what you meant by "apply this patch if you want to
 run Tor 0.2.4.x with Shadow". I originally thought you meant that I need
 to apply your patch and run more tests to make sure it is working
 correctly, since my tests from comment 15 above indicated that there were
 still problems (with your patch applied to 0.2.4.21-ish). I now think you
 may have meant that you have no plans to merge this into 0.2.4.x, and want
 Shadow users who need 0.2.4.x-stable to merge this patch manually.

 So, now that I think I understand you, I will push back a bit. With my new
 experiments completing successfully (I also ran a 3600 relay experiment
 without the infinite loop issue), does this change your mind on whether or
 not you want to merge your patch into 0.2.4.x? Remember that the Shadow
 infinite loop symptom is usually caused by busy loops in Tor; Although the
 busy loops are likely not a real performance issue in practice, removing
 them may still be desirable. Are there parts of your patch that you are
 uncomfortable merging?

 If you are still hesitant to merge, I will respect your decision and tell
 people to merge your patch now that I know Shadow+Tor works correctly with
 it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11638#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online