[tor-bugs] #13126 [Tor]: Deprecate smartlist_choose_node_by_bandwidth() ?

[Tor Bug Tracker & Wiki]

#13126: Deprecate smartlist_choose_node_by_bandwidth() ?
--------------------+------------------------------------
 Reporter:  asn     |          Owner:
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:  Tor: 0.2.6.x-final
Component:  Tor     |        Version:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------------------
 `smartlist_choose_node_by_bandwidth()` is a function that chooses a random
 node from a smartlist, weighted by the '''advertised''' bandwidth of each
 element.

 It's the older sister of `smartlist_choose_node_by_bandwidth_weights()`
 (see `node_sl_choose_by_bandwidth()`) which uses advertised bandwidth
 instead of measured. Its algorithm is old and buggy (#13066) and
 apparently documented at
 http://archives.seul.org/or/dev/Jul-2007/msg00056.html.

 Now that Tor has measured bandwidth, we should make sure that the function
 is unused and then maybe consider deprecating it. However, we should make
 it so that we are still able to gracefully handle a situation where we
 don't have measured bandwidths or weights.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13126>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online