[tor-bugs] #4244 [Tor]: Tor changes default value of DirReqStatistics, then wants to SAVECONF the new default

[Tor Bug Tracker & Wiki]

#4244: Tor changes default value of DirReqStatistics, then wants to SAVECONF the
new default
-------------------------+--------------------------------------
     Reporter:  rransom  |      Owner:
         Type:  defect   |     Status:  needs_revision
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-relay, 026-triaged-1
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------------
Changes (by arma):

 * keywords:  tor-relay, 026-triaged-1, nickm-patch => tor-relay,
     026-triaged-1


Comment:

 My bug4244b branch has a much simpler, more targeted fix. I tested it and
 it works fine for me.

 More generally, I think a trend of "thou shalt not modify the options to
 make it look like the user picked A when actually it said B" is something
 we should try to enforce.

 I use NodeFamilySets, MaxMemInQueues, Socks4ProxyAddr, etc as my precedent
 here.

 Note that this patch doesn't actually go through and fix every instance
 where we internally clobber what the torrc file said. But that makes it a
 reviewable and mergeable patch. :) Maybe it should even go into 0.2.5.x
 since TB users are seeing this one.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4244#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online