[tor-bugs] #13338 [Tor]: Rewrite tor-fw-helper in Go (or another memory-safe language)

[Tor Bug Tracker & Wiki]

#13338: Rewrite tor-fw-helper in Go (or another memory-safe language)
-----------------------------+------------------------------
     Reporter:  arma         |      Owner:  yawning
         Type:  enhancement  |     Status:  assigned
     Priority:  minor        |  Milestone:  Tor: unspecified
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  flashproxy
Actual Points:               |  Parent ID:  #5213
       Points:               |
-----------------------------+------------------------------

Comment (by yawning):

 I went and wrote code to deal with NAT-PMP routers returning a different
 external port than requested since it's allowed by the spec and happens in
 the wild.

 Turns out miniupnpd crashes when you try to remove mappings via NAT-PMP
 (Removing them via UPnP works fine).  I'm not sure if it's a quirk with
 the version on my test device or a freak accident, but this doesn't look
 good for enhancing our helper to allow for any sort of graceful cleanup,
 at least when NAT-PMP is in the picture (Since I assume crashing NAT-PMP
 stacks running on routers in the wild falls under "Unacceptable
 Behavior").

 At least stale NAT-PMP mappings only persist for 2 hours...

 (Do we really want to deal with angry users who have shitty router
 firmware that misbehaves in interesting ways from a support perspective?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13338#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online