[tor-bugs] #13393 [Tor]: Avoid signed overflow in format_time_interval, add unit tests

[Tor Bug Tracker & Wiki]

#13393: Avoid signed overflow in format_time_interval, add unit tests
------------------------+------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:
    Component:  Tor     |    Version:  Tor: unspecified
   Resolution:          |   Keywords:  tor-router
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------

Comment (by teor):

 Git blame says that this code goes all the way back to:
 r16279 at catbus:  nickm | 2007-10-30 11:14:29 -0400
 Improved skew reporting:  "You are 365 days in the duture" is more useful
 than "You are 525600 minutes in the future".  Also, when we get something
 that proves we are at least an hour in the past, tell the controller
 "CLOCK_SKEW MIN_SKEW=-3600" rather than just "CLOCK_SKEW"
 svn:r12283

 Nick(?), I'll let you decide how far back to backport it, if at all.
 (Do we backport unit tests? If not, I can split them from the function
 commit.)

 '''Repository''': ​​​https://github.com/teor2345/tor.git

 '''Branch''': format-time-interval-overflow-test
 Avoid overflow in format_time_interval, create unit tests

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13393#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online