[tor-bugs] #12951 [Tor]: BridgeAuth should add a `published` line to bridge networkstatus documents
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Oct 9 06:46:29 UTC 2014
#12951: BridgeAuth should add a `published` line to bridge networkstatus documents
------------------------+------------------------------------------------
Reporter: isis | Owner:
Type: defect | Status: needs_review
Priority: minor | Milestone: Tor: 0.2.6.x-final
Component: Tor | Version:
Resolution: | Keywords: bridgedb-parsers, stem, bridgeauth
Actual Points: | Parent ID:
Points: |
------------------------+------------------------------------------------
Comment (by isis):
Replying to [comment:5 nickm]:
> (What tools look at this? ''Will'' they choke on it?)
Stem looks for it, and
[https://gitweb.torproject.org/stem.git/blob/HEAD:/stem/descriptor/networkstatus.py#l1491
raises an error if the "published" line isn't found]. Which means that
BridgeDB (in the development branch which uses Stem)
[https://gitweb.torproject.org/user/isis/bridgedb.git/blob/refs/heads/fix/9380-stem_r3:/lib/bridgedb/parse/descriptors.py#l39
fakes a "published" line]. (This would remove the need for BridgeDB to do
that, in the future.)
I ''think'' that the `metrics-db` code should be okay, because
[https://gitweb.torproject.org/metrics-
db.git/blob/HEAD:/src/org/torproject/ernie/db/bridgedescs/SanitizedBridgesWriter.java#l517
it appears to have a catch] for when it finds lines which do not begin
with `"r"`, `"w"`, `"p"`, `"a"`, or `"s"`. Otherwise, in order to not
trigger that error, it could easily be taught about the new bridge-
networkstatus "published" lines [https://gitweb.torproject.org/metrics-
db.git/blob/HEAD:/src/org/torproject/ernie/db/bridgedescs/SanitizedBridgesWriter.java#l448
where it handles the other networkstatus descriptor headers].
Karsten, any thoughts on the above?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12951#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list