[tor-bugs] #10399 [Tor bundles/installation]: Tor Browser should be visually distinguished from Firefox to prevent user error

[Tor Bug Tracker & Wiki]

#10399: Tor Browser should be visually distinguished from Firefox to prevent user
error
------------------------------------------+---------------------------
     Reporter:  ageisp0lis                |      Owner:  erinn
         Type:  enhancement               |     Status:  new
     Priority:  trivial                   |  Milestone:
    Component:  Tor bundles/installation  |    Version:
   Resolution:                            |   Keywords:  tbb-usability
Actual Points:                            |  Parent ID:
       Points:                            |
------------------------------------------+---------------------------
Changes (by gk):

 * status:  needs_review => new
 * keywords:  tbb-usability, needs-triage => tbb-usability


Comment:

 Replying to [comment:20 dwt]:
 > I created an exploratory patch to add the plugin to for browser. Since I
 can test best on mac os, I started integrating it there.
 >
 > Well, since I really don't know the build system, I'd greatly appreciate
 some feedback on how I integrated it and how it should be done instead.
 >
 > @maintainers:
 >
 > I've attached a patch  - is that the preferred way or would you like to
 see it in a different way?

 The tor-browser-bundle bits look good to me. It seems you need to add your
 tor-browser-theme and tag to `verify-tags.sh` as well. And ideally you
 would make tags we could use and sign them with a key.

 That said I am not a fan of having yet another dialog on start-up asking
 in this case about applying the theme or not. But I can imagine just
 shipping the theme and having it off by default. Users who feel the need
 to switch themes because they are using other browsers in parallel should
 be able to do this by switching a preference. Please make sure this theme
 is no fingerprintability vector. It should not be possible for web content
 to find out whether a users has a Tor Browser specific theme activated or
 not.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10399#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online