[tor-bugs] #13672 [Tor Browser]: The circuit display dropdown should be optional.

[Tor Bug Tracker & Wiki]

#13672: The circuit display dropdown should be optional.
-----------------------------+----------------------------------
     Reporter:  yawning      |      Owner:  tbb-team
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  TorBrowserTeam201411
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------------

Comment (by arthuredelstein):

 Replying to [comment:11 gk]:
 > Replying to [comment:10 arthuredelstein]:
 > > Replying to [comment:9 gk]:
 > > > The patch looks good. I'd like to have one thing changed:
 > > >
 > > > We should make sure that we call
 > > > {{{
 > > > syncDisplayWithSelectedTab(true);
 > > > collectIsolationData(myController);
 > > > }}}
 > > > in `start()` only if there are no errors while calling
 `controller()`.
 > >
 > > I've updated the patch again. If start() throws an error, it will be
 caught and reported at in the `try { bindPrefAndInit(...) }...` part.
 Note: the anonymous error callback function is called asynchronously,
 which means it will only run after `start()` returns.
 >
 > Ok, yes. This means that `syncDisaplayWithSelectedTab(true)` is called
 even if it (later) turns out we would not have needed that due to the
 error handler getting called. Seems to be the price for having
 asynchronous things which is okay to me.
 >
 > With two more things addressed I am happy::
 >
 > -`if (line.match(/^\d\d\d /) && ` should get rid of the whitespace (git
 is complaining about)
 >
 > -If one clicks on "New Identity" and toggles the pref afterwards weird
 things are happening while Tor Browser complains about
 `gBrowser.tabContainer` being undefined:
 > {{{
 > 20:30 < arthuredelstein> I guess the whole tor-circuit-display.js file
 is tied to
 >                          the current chrome window. With New Identity we
 destroy
 >                          that window and create another. But the
 preference binding
 >                          for the old chrome window is still hanging
 around. So when
 >                          you toggle the pref, it's looking for the old
 gBrowser's
 >                          tabContainer and not finding it.
 > }}}

 I've fixed both issues and done some code cleanup. Note this patch needs
 to be applied before the forthcoming patch for #13671, which I am still
 working on.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13672#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online