[tor-bugs] #13698 [Tor]: Wrong failure report when closing parallel intro points

[Tor Bug Tracker & Wiki]

#13698: Wrong failure report when closing parallel intro points
-------------------------+---------------------------------
     Reporter:  dgoulet  |      Owner:
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-hs 025-backport
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+---------------------------------
Changes (by nickm):

 * keywords:  tor-hs => tor-hs 025-backport


Comment:

 From IRC discussion:

 re 1) Make it a negative reason, and call it something like
 END_CIRC_REASON_IP_NOW_REDUNDANT.

 re 2) Instead of that, have the stuff that currently checks `reason` when
 it's about to call `rend_client_report_intro_point_failure` check
 `orig_reason` instead.  (I worry that removing the code that changes
 `reason` could have unintended side-effects.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13698#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online