[tor-bugs] #13671 [Tor Browser]: Circuit display is broken if bridges are being used.

[Tor Bug Tracker & Wiki]

#13671: Circuit display is broken if bridges are being used.
-----------------------------+----------------------------------
     Reporter:  yawning      |      Owner:  tbb-team
         Type:  defect       |     Status:  needs_revision
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  TorBrowserTeam201411
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------------
Changes (by isis):

 * status:  needs_review => needs_revision


Comment:

 Review notes for arthuredelstein's patch:

  1. For the `readBridgeIPs()` function, I think you might run into issues
 with "vanilla" bridges, which are non-PT bridges, and so they lack a
 "type":

 {{{
 let readBridgeIPs = function (controller) {
   controller.getInfo("config-text", result => {
     let bridgeEntries = result.Bridge;
     if (bridgeEntries) {
       bridgeEntries.map(entry => {
         let [type, IPplusPort, ID] = entry.split(/\s+/),
             // Drop port number of token[1] to get IP address.
             IP = IPplusPort.split(":")[0];
         bridgeIDtoIPmap[ID] = IP;
       });
     }
   });
 };
 }}}

   Meaning a bridge line for a "vanilla" bridge, which looks like:

 {{{
 Bridge 1.1.1.1:1111 0123456789abcdef0123456789abcdef01234567
 }}}

   Would give you

 {{{
 IP = "0123456789abcdef0123456789abcdef01234567"
 }}}

  2. The indexing done above in the `bridgeIDtoIPmap` appears to be case
 sensitive. BridgeDB hands out lowercase bridge fingerprints, but there is
 no guarantee as to case since tor handles either.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13671#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online