[tor-bugs] #9531 [TorBrowserButton]: More Torbutton hangs on New Identity control port access

[Tor Bug Tracker & Wiki]

#9531: More Torbutton hangs on New Identity control port access
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mikeperry
  mikeperry              |     Status:  new
         Type:  defect   |  Milestone:
     Priority:  major    |    Version:
    Component:           |   Keywords:  tbb-usability, tbb-newnym,
  TorBrowserButton       |  MikePerry201405R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mikeperry):

 We went with blocking sockets because New Identity needed to ensure that
 it actually got a new circuit before allowing the user to do anything else
 with the browser.

 I am wondering if we should try clearing the event queue as cypherpunks
 suggested. It may be a good idea for a few reasons. We may be able to use
 https://developer.mozilla.org/en-
 US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIDOMWindowUtils#suppressEventHandling%28%29
 to suppress UI events in the meantime, if need be.

 Alternatively, we could attempt to do an async New Identity and also use
 the event suppressor to suppress UI event handling until the New Identity
 onOutputStreamReady+onInputStream callbacks come back...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9531#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online