[tor-bugs] #12114 [Tor]: Don't open DirPortFrontPage when not a relay or DirPort not set

[Tor Bug Tracker & Wiki]

#12114: Don't open DirPortFrontPage when not a relay or DirPort not set
-----------------------+------------------------------------
 Reporter:  alphawolf  |          Owner:
     Type:  defect     |         Status:  new
 Priority:  normal     |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor        |        Version:  Tor: 0.2.5.4-alpha
 Keywords:  tor        |  Actual Points:
Parent ID:             |         Points:
-----------------------+------------------------------------
 It's possible to trigger #12028 after HUP with this torrc:

 {{{
 DirPortFrontPage /etc/tor/tor-exit-notice.html
 Sandbox 1
 }}}

 {{{
 May 23 17:10:40.000 [notice] Received reload signal (hup). Reloading
 config and resetting internal state.
 May 23 17:10:40.000 [notice] Read configuration file "/usr/share/tor/tor-
 service-defaults-torrc".
 May 23 17:10:40.000 [notice] Read configuration file "/etc/tor/torrc".
 May 23 17:10:40.000 [notice] Tor 0.2.5.4-alpha-dev (git-cfd0ee514c279bc6)
 opening log file.
 May 23 17:10:40.000 [warn] sandbox_intern_string(): Bug: No interned
 sandbox parameter found for /etc/tor/tor-exit-notice.html
 May 23 17:10:40.000 [warn] Could not open "/etc/tor/tor-exit-notice.html":
 Permission denied
 May 23 17:10:40.000 [warn] DirPortFrontPage file '/etc/tor/tor-exit-
 notice.html' not found. Continuing anyway.
 }}}
 In this case `ClientOnly 1` is implied.  I think this is separate from
 #12028, because I don't think we should try to open DirPortFrontPage when
 we're not a relay, or even if we're a relay but DirPort isn't set.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12114>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online