[tor-bugs] #11476 [Tor]: Try making all memory pool and freelist code off by default, or clear-on-alloc

[Tor Bug Tracker & Wiki]

#11476: Try making all memory pool and freelist code off by default, or clear-on-
alloc
------------------------+----------------------------------------------
     Reporter:  nickm   |      Owner:  andrea
         Type:  defect  |     Status:  needs_revision
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay, security, 025-triaged
Actual Points:          |  Parent ID:
       Points:          |
------------------------+----------------------------------------------

Comment (by andrea):

 Replying to [comment:9 nickm]:
 > Suggestion:
 >
 >  * Rather than scattering ENABLE_MEMPOOLS items through our code, why
 not instead make the code in mempool.h just wrap malloc_zero() and free()
 when we're running in with mempools disabled?  That way, the rest of the
 code stays pretty.

 ...actually, because mp_pool_get() takes a cell pool as an argument, so
 I'd also have to leave 'static mp_pool_t *cell_pool = NULL;' in relay.c
 outside the #ifdef if I were keeping the call to mp_pool_get() but making
 it wrap tor_malloc_zero().

 Counter-suggestion: replace mp_pool_get() calls in relay.c with
 relay_alloc_cell() or something like that, which is #defined to either
 mp_pool_get(cell_pool) or tor_malloc_zero() as appropriate?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11476#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online