[tor-bugs] #12062 [Tor]: Audit DisableNetwork, we_are_hibernating usage

[Tor Bug Tracker & Wiki]

#12062: Audit DisableNetwork, we_are_hibernating usage
------------------------+------------------------------------
 Reporter:  nickm       |          Owner:
     Type:  defect      |         Status:  new
 Priority:  normal      |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor         |        Version:
 Keywords:  tor-client  |  Actual Points:
Parent ID:              |         Points:
------------------------+------------------------------------
 I think a lot of our DisableNetwork checks should instead check
 net_is_disabled, since so much of what we're doing turning off when the
 network is disabled is also something we're trying to turn off when we're
 hibernating.

 And probably some of our DisableNetwork checks should call
 should_delay_dir_fetches or something similar, if they're related to
 fetching non-bridge-descriptor directory stuff.

 Possibly there should be a better designed hierarchy here.

 Possibly, most of the fixes here should wait for 0.2.6, since this code is
 tricky.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12062>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online