[tor-bugs] #8402 [Tor]: Tor should help its transport proxy use a proxy, if needed.

[Tor Bug Tracker & Wiki]

#8402: Tor should help its transport proxy use a proxy, if needed.
-------------------------+-------------------------------------------------
     Reporter:  asn      |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-bridge pt flashproxy, tbb-
Actual Points:           |  needs, tbb-helpdesk-frequent
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by yawning):

 I found some more minor issues in my branch for this and as a result
 revised it a bit.

 Changes since the last time I checked it:

  *
 https://github.com/Yawning/tor/commit/3c991178926f39ffacef1d86e403f5d360d30404

 ClientTransportPlugins with associated Bridge lines that were killed due
 to lacking proxy support were being ignored, when it should have caused a
 failure.  The code now correctly deals with this, and is additionally
 closer to the existing code (Instead of using a helper routine, code is
 just moved and altered slightly).

  *
 https://github.com/Yawning/tor/commit/c4c41bb8e31ab39f2c7fe3c8f11ee727a65c3e09

 `log_failed_proxy_connection()` is calling `get_proxy_type()` despite
 having the actual proxy in a local variable.  In a world where there can
 be 2 proxy types configured (PT + other), this is bad and leads to a log
 that is misleading.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8402#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online