[tor-bugs] #11218 [BridgeDB]: bridgedb.HTTPServer.ReCaptchaProtectedResource.checkSolution() doesn't expect a deferred

[Tor Bug Tracker & Wiki]

#11218: bridgedb.HTTPServer.ReCaptchaProtectedResource.checkSolution() doesn't
expect a deferred
-------------------------+-------------------------------------------------
     Reporter:  isis     |      Owner:  isis
         Type:  defect   |     Status:  reopened
     Priority:  blocker  |  Milestone:
    Component:           |    Version:
  BridgeDB               |   Keywords:  bridgedb-https, bridgedb-0.1.6,
   Resolution:           |  easy
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by isis):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 There is a new error in that if you solve a reCaptcha CAPTCHA correctly
 (and the logs show that the reCaptcha API server even returns `true` in
 the response HTML), the deferred from checkSolution() causes the page to
 redirect to a new CAPTCHA.

 To fix this, we'll need to handle writing the response asynchronously,
 and, if I recall correctly, return `twisted.web.server.NOT_DONE_YET` from
 all of the `HTTPServer.ReCaptchaProtectedResource.render_*` methods.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11218#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online