[tor-bugs] #7472 [Tor]: Audit all calls to connection_mark_for_close()

[Tor Bug Tracker & Wiki]

#7472: Audit all calls to connection_mark_for_close()
------------------------+--------------------------------
     Reporter:  andrea  |      Owner:  andrea
         Type:  task    |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:  Tor: 0.2.4.5-alpha
   Resolution:          |   Keywords:  tor-relay
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by andrea):

 Replying to [comment:12 andrea]:
 >  * connection_handle_event_cb():
 >    - I think there's probably a bug here which could be triggered by an
 eof on an orconn which has already finished connecting, among other
 possible causes.
 >    - I believe the fix would be easy: move the conn->state ==
 OR_CONN_STATE_CONNECTING test into an inner if clause inside the
 conn->type == CONN_TYPE_OR test, and have an else clause that calls
 connection_or_close_for_error() rather than
 connection_or_connect_failed().
 >    - Demonstrating the bug or testing the proposed fix would be
 difficult due to this being bufferevent code, though.

 Created ticket #11307 for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7472#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online