[tor-bugs] #11306 [Tor]: connection_mark_all_noncontrol_connections() handles orconns wrongly

[Tor Bug Tracker & Wiki]

#11306: connection_mark_all_noncontrol_connections() handles orconns wrongly
--------------------+------------------------------------
 Reporter:  andrea  |          Owner:  andrea
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor     |        Version:  Tor: 0.2.5.3-alpha
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------------------
 This should call the right connection_or_close_*() function rather than
 connection_mark_for_close().  This can readily be observed by starting a
 client and letting it open some channels, then adding DisableNetwork 1 to
 the config and reloading, leading to warnings in the log like this:

 {{{
 Mar 24 16:21:16.000 [warn] connection_mark_for_close_(): Something tried
 to close an or_connection_t without going through channels at
 src/or/connection.c:2343
 Mar 24 16:21:58.000 [warn] connection_mark_for_close_(): Something tried
 to close an or_connection_t without going through channels at
 src/or/connection.c:2343
 }}}

 Created pursuant to connection_mark_for_close() audit task #7472.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11306>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online