[tor-bugs] #7472 [Tor]: Audit all calls to connection_mark_for_close()

[Tor Bug Tracker & Wiki]

#7472: Audit all calls to connection_mark_for_close()
------------------------+--------------------------------
     Reporter:  andrea  |      Owner:  andrea
         Type:  task    |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:  Tor: 0.2.4.5-alpha
   Resolution:          |   Keywords:  tor-relay
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by andrea):

 * conn_write_callback():
    - In the case of an or_connection_t, connection_finished_connecting()
 and connection_finished_flushing() always pass through to
 connection_or_finished_connecting() and connection_or_finished_flushing(),
 respectively.  The connection_or_finished_connecting() function always
 calls connection_or_close_for_error() correctly when it returns an error,
 and connection_or_finished_flushing() should never return an error unless
 the or_connection_t is in a bad state, and asserts first before it would
 in that case anyway.
   - Therefore, I believe conn_write_callback() is always channel-safe.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7472#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online