[tor-bugs] #8956 [pyobfsproxy]: obfsproxy should use a SOCKS proxy if Tor wants it to

[Tor Bug Tracker & Wiki]

#8956: obfsproxy should use a SOCKS proxy if Tor wants it to
-----------------------------+----------------------------
     Reporter:  asn          |      Owner:  asn
         Type:  task         |     Status:  needs_revision
     Priority:  normal       |  Milestone:
    Component:  pyobfsproxy  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:  #8402
       Points:               |
-----------------------------+----------------------------
Changes (by asn):

 * status:  new => needs_revision


Comment:

 Replying to [comment:3 yawning]:
 > pyptlib changes to support this:
 https://github.com/yawning/pyptlib/tree/bug_8402
 >
 > The patch by hellais won't apply cleanly because I changed a lot of the
 obfsproxy SOCKS code, so I will work on integrating that next, along with
 also allowing use of HTTP CONNECT proxies.

 Excellent.

 A small review. I can do the changes myself before merging if you are
 bored, no worries.

 - I try to mention the trac ticket numbers in the ChangeLog.
 - I'm quite happy that `urlparse.urlsplit` can parse our format. It would
 be great though if there was some kind of documentation on what
 `getProxy()` returns, so that users of the library can use it
 appropriately.

 Nice unittests!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8956#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online