[tor-bugs] #9683 [Tor]: circuit_unlink_all_from_channel() is a performance bottleneck?

[Tor Bug Tracker & Wiki]

#9683: circuit_unlink_all_from_channel() is a performance bottleneck?
------------------------+------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay 024-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------

Comment (by nickm):

 (The reason I think that the changes to p/n_chan might interfere with
 channel_note_destroy_pending() is that the latter function assumes that a
 circuit that has been been through circuit_mark_for_close might still be
 present in the chan_circid_map.  Then again, it might be that my patch in
 c8d9fd13edda93b049 actually simplifies this case so that the extra logic
 in channel_note_destroy_pending might not be needed any more.  I'm not
 sure.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9683#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online