[tor-bugs] #9683 [Tor]: circuit_unlink_all_from_channel() is a performance bottleneck?

[Tor Bug Tracker & Wiki]

#9683: circuit_unlink_all_from_channel() is a performance bottleneck?
------------------------+------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay 024-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------

Comment (by nickm):

 oh hey, maybe 957f252df5e8 is the problem.  We're setting p_chan and/or
 n_chan to NULL without calling circuit_set_p_circid_chan() and/or
 circuit_set_n_circid_chan().  That means that later, when circuit_free()
 (or whoeever) calls circuit_set_[pn]_circid_chan() to remove the channel
 from the chan_circid_map, it won't find the old entry.

 There's an obvious fix but I want to make sure it doesn't interfere with
 anything.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9683#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online