[tor-bugs] #8948 [Tor]: Write a "code review guidelines" page

[Tor Bug Tracker & Wiki]

#8948: Write a "code review guidelines" page
-----------------------------+--------------------------
     Reporter:  nickm        |      Owner:
         Type:  enhancement  |     Status:  new
     Priority:  normal       |  Milestone:  Tor: 0.2.???
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-doc
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------
Changes (by nickm):

 * milestone:  Tor: 0.2.5.x-final => Tor: 0.2.???


Comment:

 IMO, I'm still fine with a wall-of-text if it's targeted at reviewers.  If
 it's targeted at submitters, it should be shorter and simpler.  I'm fine
 with having a list for experienced people that's more rigorous than the
 new-folks list.

 I also like the idea of having automated checks do more, but we shouldn't
 IMO only put things on the review checklist that can be automated.

 Also, deferring. This should happen IMO but it's indefinitely-deferrable.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8948#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online