[tor-bugs] #10761 [Firefox Patch Issues]: Restoring windows and tabs causes crash on exit

[Tor Bug Tracker & Wiki]

#10761: Restoring windows and tabs causes crash on exit
--------------------------------------+-----------------------
     Reporter:  cypherpunks           |      Owner:  mikeperry
         Type:  defect                |     Status:  new
     Priority:  normal                |  Milestone:
    Component:  Firefox Patch Issues  |    Version:
   Resolution:                        |   Keywords:  tbb-crash
Actual Points:                        |  Parent ID:
       Points:                        |
--------------------------------------+-----------------------

Comment (by cypherpunks):

 We have two option to fix bug while keeping the compiler flags.
 1. Destroy stack on [https://mxr.mozilla.org/mozilla-
 central/source/security/nss/lib/base/arena.c#444 NSSArena_Destroy]
 2. Get real PR_Free address for [https://mxr.mozilla.org/mozilla-
 central/source/security/nss/lib/base/error.c#65 error_once_function] using
 [http://msdn.microsoft.com/en-
 us/library/windows/desktop/ms683212%28v=vs.85%29.aspx GetProcAddress
 function].

 First option can't to fix all another cases when modules can be unloaded
 and loaded again, or something like that.

 Second fix resolves any problems, and keeps code close to vanilla
 firefox's binaries for this case. But hides reasons of bug (it's unclear
 why thread generated with XMLHttpRequest constructor doesn't crashes
 browser like code used by add-ons now).

 What do you think?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10761#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online